hotfix: wrong type in PR #28 - Allow for subscribing to multiple channels

nim-lang / redis

Official redis wrapper for Nim.

Other

128 stars 35 forks source link

hotfix: wrong type in PR #28 - Allow for subscribing to multiple channels #30

Closed ThomasTJdev closed 2 years ago

ThomasTJdev commented 2 years ago

My PR #28 used a wrong type (#29).

The new proc passes the channel-param inside a seq[string] which creates a seq[seq[string]] since it's already a seq[string].
await r.sendCommand("SUBSCRIBE", @[channels])
# => Error: type mismatch: got <AsyncRedis, string, seq[seq[string]]>
should be
await r.sendCommand("SUBSCRIBE", channels)

ping @dom96

Araq commented 2 years ago

We should have CI support for this package...

euantorano commented 2 years ago

We should have CI support for this package...

We do have some old CI using CircleCI: https://github.com/nim-lang/redis/blob/master/.circleci/config.yml

it just needs converting to GitHub Actions or something more visible.