search

nim-lang / smtp

SMTP client implementation, adapted from the Nim standard library
MIT License
10 stars 5 forks source link

fix `connect` `dial` before wrap ssl, revert partial of https://github.co… #11

Closed bung87 closed 1 month ago

bung87 commented 7 months ago

…m/nim-lang/smtp/commit/7eae0f0d834ffe6517031b4570e9aa86ea7c26bf

fix https://github.com/nim-lang/smtp/issues/12

ringabout commented 7 months ago

ref https://github.com/nim-lang/smtp/pull/7

cc @mildred

ThomasTJdev commented 5 months ago

What do we need to get this PR merged? @mildred ?

ThomasTJdev commented 3 months ago

Any progress here? What would be needed to proceed?

ringabout commented 2 months ago

Can we revert https://github.com/nim-lang/smtp/commit/7eae0f0d834ffe6517031b4570e9aa86ea7c26bf and https://github.com/nim-lang/smtp/pull/8 fully?

bung87 commented 2 months ago

I don't think worth to.

ThomasTJdev commented 1 month ago

I can remove/redo the code and provide a PR with a detailed description - @ringabout would that be sufficient?

ringabout commented 1 month ago

I can remove/redo the code and provide a PR with a detailed description -

It would be appreicated, thank you!

bung87 commented 1 month ago

close as problem gone by revert