clean up symbol error reporting

zerbina commented 3 months ago

Summary

don't report "cannot call" error when using symbol of routines where the definition has an error
don't report "only identifier found is an error" when using let/ var/const symbol where the initializer expression has an error
these errors don't provide any additional information and only clutter compiler and nimsuggest output

use a common erroneous symbol handling path in semSym
don't turn skLet, skVar, and skConst into skErrors when the definition AST has an error
use the silent adWrappedSymError diagnostic for erroneous callees
remove the CalleeHasAnError diagnostic and report
add tests to make sure the new error reporting behaviour works
adjust the tpointerprocs.nim, which is affected by the different error reporting

saem commented 3 months ago

/merge

github-actions[bot] commented 3 months ago

Merge requested by: @saem

Contents after the first section break of the PR description has been removed and preserved below:

## Notes for Reviewers * builds upon #1372