packedsets: reimplement using roaring bitmap - Githubissues

nim-works / nimskull

An in development statically typed systems programming language; with sustainability at its core. We, the community of users, maintain it.

https://nim-works.github.io/nimskull/index.html

Other

275 stars 39 forks source link

packedsets: reimplement using roaring bitmap #1412

Closed alaviss closed 1 month ago

alaviss commented 1 month ago

Summary

what changed and how?
why are we changing it?

Details

info that couldn't fit into the summary
relevant details; tricky parts
anything else

Fixes full_issue_url

Notes for Reviewers

Todo list:

[ ] Debug the current performance deficit when used by the compiler
[ ] Write a proper PR description
- [ ] Benchmark between HashSet, old PackedSet and Roaring against the compiler + some test dataset
[ ] Remove packedsets0, which is the old PackedSet.
[ ] Write more tests for containers and roaring