nim-works / nimskull

An in development statically typed systems programming language; with sustainability at its core. We, the community of users, maintain it.
https://nim-works.github.io/nimskull/index.html
Other
279 stars 39 forks source link

openssl, net: remove openssl pre-1.1.1 and libressl support #1435

Closed alaviss closed 3 months ago

alaviss commented 3 months ago

Summary

Remove support for OpenSSL older than 3.0, as it has reached EoL and should no longer be used in production.

Since version 1.1.1 is still widely used in LTS distributions such as RHEL 8 or Ubuntu 20.04, support for it is retained, however.

Details

alaviss commented 3 months ago

Unfortunately the SSL hacks must stay to shim 1.1 and 3.0, so I brought those back.

saem commented 3 months ago

/merge

github-actions[bot] commented 3 months ago

Merge requested by: @saem

Contents after the first section break of the PR description has been removed and preserved below:


### Notes for reviewers * This also removes support for the bundled LibreSSL in macOS. The bundled LibreSSL in macOS is [*frozen*](https://developer.apple.com/forums/thread/89051?answerId=267538022#267538022) and never receives updates as Apple want to keep binary compatibility. Apple discourages the use of this library, so we shouldn't use it as well. * As an artifact of using `dlopen` for OpenSSL, this will not work on Apple Silicon devices by default even if `openssl` is installed via Homebrew due to https://github.com/Homebrew/brew/issues/13481.