search

nimahkh / soft_bun

A lightweight and framework-agnostic reactivity system implemented in TypeScript
Other
10 stars 1 forks source link

fix/enable resolution of nested object properties #27

Closed Mostafa-Mohammadi closed 1 year ago

Mostafa-Mohammadi commented 1 year ago

Hello dear Nima,

This pull request addresses the issues described in #25

I've made some crucial bug fixes that enhance the functionality of the pairValues method and introduce a new method called getNestedPropertyValue. These changes allow for the seamless handling of nested property paths within reactive expressions. Below, I've outlined the modifications and their benefits:

  1. Modified Regular Expression in pairValues Method
  2. Added getNestedPropertyValue Method
  3. Updated pairValues Method to Utilize getNestedPropertyValue

These changes collectively ensure that the codebase now offers robust support for accessing nested properties within reactive expressions.

Mostafa-Mohammadi commented 1 year ago

The previous pull request has been closed unexpectedly. The review concerning the incorporation of various test cases has been successfully addressed.

nimahkh commented 1 year ago

The previous pull request has been closed unexpectedly. The review concerning the incorporation of various test cases has been successfully addressed.

Awesome, well done Mostafa, As we are following Semantic release commit messages format, it is crucial to have commit messages which are observed the same formatting, otherwise our package version will not bump, Could you please add an empty comment with the same format? I have to add it as a lint rule to avoid different commenting formats, Thanks

Mostafa-Mohammadi commented 1 year ago

The previous pull request has been closed unexpectedly. The review concerning the incorporation of various test cases has been successfully addressed.

Awesome, well done Mostafa, As we are following Semantic release commit messages format, it is crucial to have commit messages which are observed the same formatting, otherwise our package version will not bump, Could you please add an empty comment with the same format? I have to add it as a lint rule to avoid different commenting formats, Thanks

Of course, I apologize for overlooking that requirement. Thank you for bringing it to my attention.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.7.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: