nimaid / binary-waterfall

A Raw Data Media Player
GNU General Public License v3.0
87 stars 3 forks source link

Add error handling for export #4

Closed megascrapper closed 7 months ago

megascrapper commented 7 months ago

Have the main window catch any errors thrown by the renderer and display them as a critical message box:

Example error message box

Previously, any errors that occurred during export (e.g. out of storage) would go uncaught and crash the entire program, potentially leaving a huge mess behind as it doesn't have the chance to cleanup the files.

How to test

Create some condition that might lead to an error, or intentionally throw one by placing something like raise Exception("Example error thrown in export_video()") in the Renderer export methods.

nimaid commented 7 months ago

Thanks for helping out! Merged.