search

nimasaj / uBOPa

Filterlist to block ads. Compatible with most ad blockers, but specifically written for uBlock Origin
MIT License
31 stars 3 forks source link

moderndl.com ads and breakage #16

Closed MasterKia closed 2 years ago

MasterKia commented 2 years ago

Fix 1: moderndl.com##.pushe-prompt-is-rtl.pushe-prompt-top-center.pushe-prompt-top.prompt Fix 2:

moderndl.com#@#*[id^="ads_"]
moderndl.com#@#*[alt*="تبلیغ"]

Fix 3: moderndl.com##.m-ads

Break5 Break6 Break7

nimasaj commented 2 years ago

Thanks for reporting the issues. Nr.1 cannot be applied since this is not an ad issue, but a website issue. Website developer should fix it either using cookies to avoid popping it up all the time, or some other methods to stop it.

The other suggestions were made into the list, https://github.com/nimasaj/uBOPa/commit/4009d33ac8673508e1d4c26c7dc758e673e81582.

MasterKia commented 2 years ago

Then the first issue should be addressed in the (upcoming?) annoyances filter.

MasterKia commented 2 years ago

Update

##.pushe-prompt-is-rtl.pushe-prompt-top-center.pushe-prompt-top.prompt example on moderndl.com and filmvision.ir: image

nimasaj commented 2 years ago

I see this is coming to more and more websites and it's not a specific website issue, therefore, it can be added to the list, https://github.com/nimasaj/uBOPa/commit/4b99f83e5d88e5a2768baf62795ba87cc8ceb6ea. To record more samples, the following websites are also using this script. https://mybia4music.com/ https://www.shirazsong.in/ https://nicmusic.net/ https://www.jenabmusic.com/

Please check out with the updated list and report if it works for you.

MasterKia commented 2 years ago

Thanks for the investigation of this issue, it's fixed with the latest commit.