search

nimbis / cmsplugin-newsplus

An improved version of cmsplugin-news
BSD 2-Clause "Simplified" License
5 stars 10 forks source link

Add missing migration #6

Closed vstoykov closed 8 years ago

vstoykov commented 9 years ago

Django's manage.py makemigrations will automaically create this migration. Probably is missed somewhere down the road.

ericamador commented 8 years ago

I have been unable to reproduce this. Can you let me know what version of Django, Django-CMS, and Python you are using?

vstoykov commented 8 years ago

Sorry for the delay.

Python 3.4

Django==1.8.4 django-cms==3.1.3

vstoykov commented 8 years ago

Actually now I look at generated code for both fields in Initial migration and my migration. The only difference is that in the initial migration some of the strings are marked as bytestrings.

In 0001-initial.py:

models.ImageField(upload_to=b'news_images')

In my:

models.ImageField(upload_to='news_images')

The same is for SlugField but for unique_for_date argument.

Probably my PR is not necessary, and initial migration need to be fixed to use string and not bytestring.