search

nimble-code / Cobra

An interactive (fast) static source code analyzer
139 stars 31 forks source link

Compares type names of encountered extern and original declarations #30

Closed zubariaayub634 closed 2 years ago

zubariaayub634 commented 2 years ago

In the given code, the types of the two tokens are being compared. Since the current token . and the token r are both data types r.type = type .type = type and hence r.type == .type is always true

Hence their .txt should be compared instead

nimble-code commented 2 years ago

indeed -- it's fixed

zubariaayub634 commented 2 years ago

It wouldve been appreciated if my pull request were merged into the repo, as I want to add open source contributions to my profile.

On Fri, Jan 21, 2022, 11:45 PM nimble-code @.***> wrote:

Closed #30 https://github.com/nimble-code/Cobra/pull/30.

— Reply to this email directly, view it on GitHub https://github.com/nimble-code/Cobra/pull/30#event-5934068426, or unsubscribe https://github.com/notifications/unsubscribe-auth/APAXGU3K6UPFVUHXJQEDEWTUXGSU3ANCNFSM5MQGC64Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

nimble-code commented 2 years ago

sorry -- I fixed it as soon as you reported it.

zubariaayub634 commented 2 years ago

No problem, hopefully more to come

On Fri, Jan 21, 2022, 11:54 PM nimble-code @.***> wrote:

sorry -- I fixed it as soon as you reported it.

— Reply to this email directly, view it on GitHub https://github.com/nimble-code/Cobra/pull/30#issuecomment-1018775261, or unsubscribe https://github.com/notifications/unsubscribe-auth/APAXGUZLT7IDHTJBZQLHQ5LUXGTXZANCNFSM5MQGC64Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>