nimble-dev / compareMCMCs

Tools for comparing MCMC efficiency from nimble and/or other engines
GNU General Public License v3.0
1 stars 2 forks source link

Stan example in Vignette #16

Closed rowlandseymour closed 2 years ago

rowlandseymour commented 3 years ago

This is a great vignette; it's clear, accessible and has good examples in it. But I would have like to have seen an example of how Stan can be used here. I got it to work eventually but it involved a bit of trial and error. I know that different parts of statistics use different computational platforms, so I think including Stan would help open up the user base somewhat.

The only place Stan is currently mentioned in the vignette is here: https://github.com/nimble-dev/compareMCMCs/blob/7faa8c1cb251a5a20e4f5c744dd73b61ddf955ac/compareMCMCs/vignettes/compareMCMCs.Rmd#L32

openjournals/joss-reviews#3844

perrydv commented 2 years ago

Hi @rowlandseymour Thanks for the suggestion. We've added a Stan example to the vignette and also included Stan in test coverage.

rowlandseymour commented 2 years ago

Thanks @perrydv. I think this really helps.