search

nimble-dev / nimble

The base NIMBLE package for R
http://R-nimble.org
BSD 3-Clause "New" or "Revised" License
158 stars 24 forks source link

Fix RW_multinomial sampler #1341

Closed danielturek closed 11 months ago

danielturek commented 1 year ago

Fixes dubious results in RW_multinomial sampler, by correcting the reverse proposal probability in the MH acceptance probability calculation.

This addresses NCT issue # 486.

danielturek commented 1 year ago

I'm fine with anyone merging this any time, I have confidence in the (updated) RW_multinomial sampler. Presumable if I just leave this open, @paciorek will merge it at some point.

paciorek commented 11 months ago

Merged manually to deal with conflicts.