nimble-dev / nimble

The base NIMBLE package for R
http://R-nimble.org
BSD 3-Clause "New" or "Revised" License
158 stars 24 forks source link

eigenization of besselK - is `toEigenize` specified correctly? #1366

Closed paciorek closed 9 months ago

paciorek commented 11 months ago

In sizeRecyclingRuleBesselK, we have code$toEigenize <- TRUE instead of assigning "yes". Check this as it seems inconsistent at best and possibly a bug.

paciorek commented 11 months ago

BesselK calcs seem fine, including with recycling. Seems strange that this would all work when code$toEigenize <- TRUE.

I haven't delved more deeply, but I'm changing to be "yes" in branch fix_besselK.