addSampler arg names are now nodeWiseAssignment and scalarElementsAsNodes

nimble-dev / nimble

The base NIMBLE package for R

http://R-nimble.org

BSD 3-Clause "New" or "Revised" License

156 stars 23 forks source link

Closed danielturek closed 8 months ago

danielturek commented 9 months ago

The title says it all.

danielturek commented 9 months ago

Addresses NCT issue # 475

paciorek commented 9 months ago

LGTM. @perrydv should weigh in too.

Wording suggestion - for the two deprecation messages, I suggest:

messageIfVerbose('  [Warning] `expandTarget` argument name has been deprecated; please use `nodeWiseAssignment.')

I care less about exact wording than I do about use of messageIfVerbose.

danielturek commented 8 months ago

@paciorek I'll leave it up to you to merge this, whenever the time is right.