search

nimble-dev / nimble

The base NIMBLE package for R
http://R-nimble.org
BSD 3-Clause "New" or "Revised" License
160 stars 24 forks source link

fix issue 1356 by not warning of missing nf via `sizeOptim` #1378

Closed paciorek closed 10 months ago

paciorek commented 11 months ago

also adding warning of missing vars in sizeReturn.

paciorek commented 11 months ago

Fixes issue #1356

paciorek commented 11 months ago

This is getting hung up on the test-ADlaplace issue but o.w. seems ok, so I will merge once @perrydv takes a look.

paciorek commented 11 months ago

Actually there is also a bit of tangle in terms of tests added for issue #1365 / PR #1379 causing the Linux test failure seen here. Once Perry takes a look I will probably just merge this in and deal with any testing fallout directly on devel.

perrydv commented 10 months ago

I've tried changing to fix to the second aspect of this, the spurious warning for the fn or gr argument to nimOptim if it is an RCfunction.