search

nimble-dev / nimble

The base NIMBLE package for R
http://R-nimble.org
BSD 3-Clause "New" or "Revised" License
156 stars 23 forks source link

fix besselK to have standard `toEigenize` #1385

Closed paciorek closed 8 months ago

paciorek commented 9 months ago

@perrydv wanted to look at this, in part to figure out why it hasn't caused a problem already.

paciorek commented 8 months ago

This fixes issue #1366

perrydv commented 8 months ago

@paciorek LGTM but one note on merging everything together. The changes in #1396 will, I think affect the besselK recycling rule C++ implementation. Specifically I would check what happens if you give a matrix argument. I think it should return a vector using all the elements, but it is worth checking or adding a test if necessary.