search

nimble-dev / nimble

The base NIMBLE package for R
http://R-nimble.org
BSD 3-Clause "New" or "Revised" License
158 stars 24 forks source link

Remove compareMCMCs #1436

Closed perrydv closed 6 months ago

perrydv commented 7 months ago

I think we could remove the placeholder for the original compareMCMCs (just giving a message) that is now deprecated in favor of package compareMCMCs (which will get an update soon).

danielturek commented 7 months ago

@perrydv Agreed.

paciorek commented 6 months ago

Yes. I'll just put it on my to-do list and take care of with other minor things.

paciorek commented 6 months ago

Working on this now.

@danielturek it appears on initial glance that the only use case for the returnComponents argument to readBUGSmodel was the now defunct MCMCsuite. What do you think about me removing that argument?

danielturek commented 6 months ago

@paciorek I, personally, think this returnComponents option is useful to have. But that said, if the momentum is to clean up and remove it, I would understand.

paciorek commented 6 months ago

I'm happy to leave it.

Taking out the placeholders is done on devel, so closing this.