search

nimble-dev / nimble

The base NIMBLE package for R
http://R-nimble.org
BSD 3-Clause "New" or "Revised" License
160 stars 24 forks source link

tweak BFGS call #1438

Closed perrydv closed 6 months ago

perrydv commented 7 months ago

There was a small weird thing in how we call BFGS from compiled optim. I don't think it is a bug. This PR fixes it. I don't think there will be any change in behavior but I am not 100% sure.

perrydv commented 6 months ago

@paciorek This failed in test-ADdists. It is not clear how my tweak in nimOptim's C++ code could have impacted test-ADdists. Do you think this could be something unrelated to my change?

paciorek commented 6 months ago

Arggh - seems like another heisenbug - I ran test-ADdists.R locally under fix-BFGS and things seemed fine.

paciorek commented 6 months ago

Merging as we are dealing with the testing issue elsewhere.