Closed perrydv closed 3 months ago
@perrydv ok to merge given the Win/MacOS failures are unrelated?
@paciorek I'm more cautious about this branch since it does change some pervasive internals like the distClass
objects, even if only slightly. I might have missed the test outcomes. At the moment they are showing as canceled. Did they otherwise run and pass except for the current general test issues we're seeing?
@perrydv I think my commit was from the GH browser just dealing with a trivial merge conflict.
Linux tests passed on your last commit - Win/Mac failures were unrelated.
So that sounds like we are ready to merge.
We recently added support (for the imminent release) for using methods of nimbleObjects as user-defined distributions and functions in models.
There were shortcomings in support for AD with these new features. This PR attempts to clean up those gaps and also add tests, which were obviously missing or we would have noticed the shortcomings earlier.
I have locally successfully run
test-ADbasics
, where most of the new testing resides. Let's see any other issues with CI testing.Incidental to its main purpose, this PR has several other pieces:
modelDef
objects retain the user environment (previously it was retained only inBUGSdecl
objects)distClass
and how its objects are populated so that they get thebuildDerivs
field from any user-defined distribution (andTRUE
orFALSE
for built-in distributions).modelDef
method for checking for AD support in a distribution.