nimble-dev / nimble

The base NIMBLE package for R
http://R-nimble.org
BSD 3-Clause "New" or "Revised" License
156 stars 23 forks source link

AGHQ and nimOptim #1455

Closed perrydv closed 3 months ago

perrydv commented 4 months ago

@paul-vdb @weizhangstats @paciorek @danielturek

This is the long-awaited PR with AGHQ from @paul-vdb along with more flexible nimOptim and many other changes.

A few quick notes:

perrydv commented 3 months ago

Updates to this PR:

Remaining to-dos:

perrydv commented 3 months ago

I cleaned up tests. Two notes:

paul-vdb commented 3 months ago

@perrydv I wrote some RTMB code that does Laplace or AGHQ in a very basic way as a reality check. The beta-binomial example in the test takes a lot of nodes to be accurate. It might be helpful as a check that we didn't break anything in this update for some of the other examples (code is commented out on line 271 of test ADaghq) and very easy to setup for other examples.

I like the simplification of the setup code that you've done moving it into its own function. Reading through updateSettings that looks really good. Much better to have it all in one place as it was getting messy with the number new methods added for such small controls.

To add is a test on 2 dimension AGHQ in test-ADaghq.

paciorek commented 3 months ago

merging so can proceed with other steps. We can check testing on devel.