updated checks for configureRJ

danielturek commented 2 months ago

Updated checks for configureRJ function:

Did basic refactoring
Fixed a bug in one set of checks (previously was omitting a call to skip)
In the case of "more than one sampler already on target node", we now bail out of configureRJ routine, rather than toggling the first sampler, and removing the other samplers (the previous behaviour)
New check added: when an existing sampler is updating the targetNode and also other nodes, we now bail out of the configureRJ routine (this case was the impetus for this work).

Also added relevant testing.

danielturek commented 2 months ago

Fixes #1471

salleuska commented 2 months ago

Thanks, Daniel for taking care of this! I had it on a to-do list since the user discussion, but I haven't had much time to think about it.

danielturek commented 2 months ago

@salleuska No problem!

nimble-dev / nimble