search

nimble-dev / nimble

The base NIMBLE package for R
http://R-nimble.org
BSD 3-Clause "New" or "Revised" License
156 stars 23 forks source link

fix uncompiled use of updateSettings in Laplace or AGHQ #1480

Closed perrydv closed 2 months ago

perrydv commented 2 months ago

A minor bug in buildAGHQ came to my attention. If updateSettings method is used prior to compilation with inputs that change constant_init_par, it can break the one_time_fixes system by omitting the trailing -1 needed to confirm it is a vector for compilation. This PR fixes that. I have not added a test that triggers the bug and shows it is fixed by this PR. First I am putting this up to run current tests and can add a new test later.

danielturek commented 2 months ago

@perrydv @paciorek Should these changes be made in nimble-dev/nimble, or in nimbleQuad?

I understand the importance of keeping the nimble-dev/nimble release of Laplace/AGHQ correct. But this workflow may not be realistic, for eventual migration (of any number of such changes) to nimbleQuad.

paciorek commented 2 months ago

nimble is still the active location for Laplace/AGHQ so we definitely need it here. And we need it in nimbleQuad (thanks @danielturek for the issue posted there).

I'm hoping that next nimble release removes Laplace/AGHQ so this does not repeat.