search

nimble-dev / nimbleEcology

18 stars 9 forks source link

dCJS enforces probSurvive >= (len - 1), but rCJS enforces probSurvive == len - 1 #22

Closed dochvam closed 3 years ago

dochvam commented 3 years ago

This creates an inconsistency where inputs that work fine for probability calculation errors during simulation, but there isn't a good reason simulation should behave differently.

I suggest we change the condition in dCJS to match that in rCJS. This is stricter and there's a risk it'd break something someone is doing, although I'd argue that it's too easy to misinterpret what's going on without this.

dochvam commented 3 years ago

Addressed in nimbleEcology 0.4. We decided to loosen the restriction in rCJS.