Installation has some warinings

JorgMuskens commented 4 years ago

Hi Dan, Today a migrated to the lastest master build. I saw that the package.json file was modified and removed yarn.lock and node_modules directory/ in the hope the swagger warning were solved. but i still have them on install. I know this not a big issue as it works but still can be adressed.

yarn install v1.22.4
info No lockfile found.
[1/4] Resolving packages...
warning ari-client > swagger-client@2.0.26: No longer maintained, please upgrade to swagger-client@3.
warning ari-client > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
warning ari-client > swagger-client > shred > sprintf@0.1.1: The sprintf package is deprecated in favor of sprintf-js.
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
Done in 66.47s.

I am not sure if moving to swagger 3 will break the dialogflow code and have not tested it yet. The other two packages i believe are linked so not sure if we can ignore these. We can address this later as it has no further impact but i would look nice if there were no warnings 😃

danjenkins commented 4 years ago

nothing we can do about swagger unfortunately. Thats an underlying issue in the node lib for the ARI. request and sprintf should be addressed but inside the node lib for the ARI, not here

JorgMuskens commented 4 years ago

Update: I removed the full directory and git cloned it again. Then it works with no warnings 😕

danjenkins commented 4 years ago

lol, that erm... makes no sense!

JorgMuskens commented 4 years ago

I will close this with my head scratched

nimbleape / asterisk-dialogflow-ari-bridge

Installation has some warinings #7