search

nimbleape / asterisk-dialogflow-rtp-audioserver

MIT License
38 stars 18 forks source link

clearing down audio timeouts #39

Closed 0x1stvan closed 1 month ago

0x1stvan commented 1 month ago

Clearing timeouts to fix audio distortions and dialogflow speak

More info here: https://github.com/nimbleape/asterisk-dialogflow-rtp-audioserver/issues/37

0x1stvan commented 1 month ago

Looks like it fixes it, but need more testing. I'm open for PR improvements.

danjenkins commented 1 month ago

I'll take a proper look when I can, try not changing other things in the PR like whitespace etc... makes looking at it far easier. I know there are def things in there that need updating etc... but those should be in a separate PR :)

First glance it looks like that should work fine.

0x1stvan commented 1 month ago

I'll take a proper look when I can, try not changing other things in the PR like whitespace etc... makes looking at it far easier. I know there are def things in there that need updating etc... but those should be in a separate PR :)

First glance it looks like that should work fine.

Working on to keep the original comments and format.

0x1stvan commented 1 month ago

@danjenkins You can check the last commit, i keep the original code just added the changes. https://github.com/nimbleape/asterisk-dialogflow-rtp-audioserver/pull/39/files

danjenkins commented 1 month ago

Looks good, I haven't tested it but I see no reason why this wouldn't work!