nimblehq / elixir-templates

Our optimized Elixir templates used in our projects
https://nimblehq.co
MIT License
86 stars 6 forks source link

Fix the Icon Sprite #201

Closed andyduong1920 closed 2 years ago

andyduong1920 commented 2 years ago

What happened

The SVG sprite needs to be updated due to the migration to EsBuild

Insight

1/ Update the generate CLI command as we moved the images to priv folder already. 2/ Update the IconHelper to include the priv--static--images--icons-- because the icon files now located in the priv/static/images/icons folder, which is different with the assets/package.json location, the SVG sprite generate the path to the sharp id

Proof Of Work

Tested on client project.