[gh-307] Fix the invalid disable Credo rule on API variant - Githubissues

nimblehq / elixir-templates

Our optimized Elixir templates used in our projects

https://nimblehq.co

MIT License

86 stars 6 forks source link

[gh-307] Fix the invalid disable Credo rule on API variant #308

Closed byhbt closed 1 year ago

byhbt commented 1 year ago

Resolves https://github.com/nimblehq/elixir-templates/issues/307

What happened 👀

[x] Extract the disable Credo rule into the credo helper.
[x] Add checking file_exist?/1 in case a new project is created with --no-html, the page_controller does not exist there.
[x] Rename fetch_andinstall => `install_` to make it cleaner.
[x] Refactor the template.ex: using alias to reference to the helper methods instead of import

Insight 📝

n/a

Proof Of Work 📹

The test should pass.