nimblehq / flutter-templates

A repository contains Flutter templates that are used by Nimble developers
MIT License
24 stars 4 forks source link

[#258] Update the base template structure to follow the Clean Architecture folder structure #262

Closed doannimble closed 1 year ago

doannimble commented 1 year ago

What happened 👀

Our current template base structure under lib/ folder is not up to date with the Clean Architecture folder structure. There is no clear separation between the data, domain, and presentation layers. Also, the current structure does not fully follow the Clean Architecture components naming. Therefore, the project outcome lacks a sound foundation to commence development.

Insight 📝

Proof Of Work 📹

The template is able to be built normally.

luongvo commented 1 year ago

@doannimble please rebase to clean up merge commit, and add necessary meta info for this PR 🙏

doannimble commented 1 year ago

@luongvo Rebased. Please let me know if we need to add more necessary infor 🙏

luongvo commented 1 year ago

@doannimble why do we have some commits tagged with #169 task in this PR? 🤔 If they belong to this #258, could you please "reword" them?

manh-t commented 1 year ago

@doannimble We currently do not have any files in the data/remote/models/requests directory, so it has not been created. Would it be possible to create a .keep file in the directory to ensure it appears in our template? This is a practice from react-template 😄

luongvo commented 1 year ago

@doannimble We currently do not have any files in the data/remote/models/requests directory, so it has not been created. Would it be possible to create a .keep file in the directory to ensure it appears in our template? This is a practice from react-template 😄

Possible, nice suggestion imo cc @doannimble

doannimble commented 1 year ago

@manh-t Good to know, I've updated. cc @luongvo