nimblehq / infrastructure-templates

For IaaS and PaaS as codes
MIT License
10 stars 0 forks source link

[#133] Change the generated project structure to be similar to our recent projects #167

Closed hoangmirs closed 1 year ago

hoangmirs commented 1 year ago

What happened 👀

Insight 📝

Run ./bin/dev generate generated-infra to check the generated project.

Proof Of Work 📹

The following folder structure is the result of ./bin/dev generate generated-infra

Details ``` generated-infra/ ├── base │ ├── main.tf │ ├── outputs.tf │ ├── providers.tf │ └── variables.tf ├── modules │ ├── alb │ │ ├── main.tf │ │ ├── outputs.tf │ │ └── variables.tf │ ├── bastion │ │ ├── main.tf │ │ └── variables.tf │ ├── ecr │ │ ├── main.tf │ │ ├── outputs.tf │ │ └── variables.tf │ ├── ecs │ │ ├── main.tf │ │ ├── service.json.tftpl │ │ └── variables.tf │ ├── log │ │ ├── main.tf │ │ ├── outputs.tf │ │ └── variables.tf │ ├── rds │ │ ├── main.tf │ │ ├── outputs.tf │ │ └── variables.tf │ ├── s3 │ │ ├── main.tf │ │ ├── outputs.tf │ │ └── variables.tf │ ├── security_group │ │ ├── main.tf │ │ ├── outputs.tf │ │ └── variables.tf │ ├── ssm │ │ ├── main.tf │ │ ├── outputs.tf │ │ └── variables.tf │ └── vpc │ ├── main.tf │ ├── outputs.tf │ └── variables.tf └── shared ├── main.tf ├── outputs.tf ├── providers.tf └── variables.tf 14 directories, 37 files ```
Nihisil commented 1 year ago

Should we rename log to cloudwatch? This has been my concern, since all other modules are named after the service (e.g. rds instead of db), but only the log module is different.

hoangmirs commented 1 year ago

Should we rename log to cloudwatch? This has been my concern, since all other modules are named after the service (e.g. rds instead of db), but only the log module is different.

@Nihisil Good catch. Thanks, I changed it in https://github.com/nimblehq/infrastructure-templates/pull/167/commits/cde353c8e64907abdd0f0db61903d59d93d33e3c