[#191] Add prompt to enable Terraform Cloud - Githubissues

nimblehq / infrastructure-templates

For IaaS and PaaS as codes

MIT License

10 stars 0 forks source link

[#191] Add prompt to enable Terraform Cloud #206

Closed hoangmirs closed 1 year ago

hoangmirs commented 1 year ago

Close #191

What happened 👀

Add Terraform Cloud add-on
Refactor Version Control add-on and make it isolated
Remove cloud block in skeleton files
Fix tests to work with the new add-ons

Insight 📝

We implemented the VersionControl prompt in the generate command file, but it will make the versionControl depends on that command. We need to make it isolated so that we can call it in anywhere
In each add-on, I use the value terraformCloudEnabled instead of enabled because with this, we can test them easier by passing all values in a single mock object.

Proof Of Work 📹

Tests are passed
The prompt is shown when creating a new project:

hoangmirs commented 1 year ago

Optional suggestion: Currently, if I must use BitBucket, I will answer yes to the question Would you like to enable git version control?, but the next step will leave me with no choice but "GitHub". This can be confusing, but it's not a blocker 😇

Ah, I got your point. I added the supported options to the questions here. Later, we will find another way to handle it 👍