nimblehq / infrastructure-templates

For IaaS and PaaS as codes
MIT License
10 stars 0 forks source link

[#234] Add version increment workflow #237

Closed hoangmirs closed 9 months ago

hoangmirs commented 10 months ago

What happened 👀

Insight 📝

Proof Of Work 📹

Tested on https://github.com/nimblehq/infrastructure-templates/actions/runs/6755199957 Generated PR: https://github.com/nimblehq/infrastructure-templates/pull/253

olivierobert commented 10 months ago

We could consider moving most of the logic to a custom action (e,g., it could be with JS) as it would make it easier to break the logic into functions (with good names). Bash style if/else is kind of confusing at times.

hoangmirs commented 10 months ago

We could consider moving most of the logic to a custom action (e,g., it could be with JS) as it would make it easier to break the logic into functions (with good names). Bash style if/else is kind of confusing at times.

Agree, we'll have other separate actions to deal with each step, and combine them into a shared step later.