nimblehq / jetpack-compose-crypto

This is an sample Crypto market prices app built with Jetpack Compose
https://nimblehq.co/
MIT License
21 stars 5 forks source link

[#4] Implement UI Today's profit card on Home screen #11

Closed Wadeewee closed 2 years ago

Wadeewee commented 2 years ago

https://github.com/nimblehq/jetpack-compose-crypto/issues/4

What happened 👀

When the user launches the app, it will show the portfolio amount and today's profit on Home page.

Insight 📝

Proof Of Work 📹

https://user-images.githubusercontent.com/28002315/176336915-b6d478d7-5e52-48e4-ac76-344788eab684.mov

hoangnguyen92dn commented 2 years ago

@Wadeewee May I know the progress? Can I start to review this PR? 🙏

Wadeewee commented 2 years ago

@Wadeewee May I know the progress? Can I start to review this PR? 🙏

@hoangnguyen92dn Yes, This PR is ready to review, but except for the elevation issue(the third concern) regarding this thread, I think better to create a new ticket to work on this later 🙏 but If you have a quick solution, please let me know 🙇‍♀️

luongvo commented 2 years ago

@Wadeewee Could you please help us adding a gitignore file in buildSrc folder?

buildSrc/.gitignore

/build

image

luongvo commented 2 years ago

@hoangnguyen92dn I think we should consider splitting the shadow effect AC into a new ticket 💭

image

luongvo commented 2 years ago

@hoangnguyen92dn we should merge this PR soon, or you're planning to merge it after #9? 🤔

luongvo commented 2 years ago

@hoangnguyen92dn we should merge this PR soon, or you're planning to merge it after #9? 🤔

Since the PR #9 is done, I think now we can wait a bit.

hoangnguyen92dn commented 2 years ago

@luongvo I will merge #9 then merge this PR then we will have a new build on FAD once this PR merged 🚀

hoangnguyen92dn commented 2 years ago

Go go 🚀