Closed Wadeewee closed 2 years ago
@Wadeewee Could you please rebase to #11 then I can have a review? 👋
@Wadeewee Should we drop these commits after rebasing?
@Wadeewee Please update to get rid of issue reported by Detekt 🙏
8 Warnings | |
---|---|
:warning: | /home/runner/.gradle/caches/transforms-2/files-2.1/4f51a96613303924c40cd417b6993d48/jetified-timber-4.7.1/jars/lint.jar#L0 - Lint found an issue registry (timber.lint.TimberIssueRegistry ) which is older than the current API level; these checks may not work correctly.
Recompile the checks against the latest version. Custom check API version is 1 (3.1), current lint API level is 8 (4.1) |
:warning: | /home/runner/.gradle/caches/transforms-2/files-2.1/f7ef8adf73d1f4d85ea6c92e60c71486/jetified-annotation-experimental-1.0.0/jars/lint.jar#L0 - Lint found an issue registry (androidx.annotation.experimental.lint.ExperimentalIssueRegistry ) which did not specify the Lint API version it was compiled with.
This means that the lint checks are likely not compatible. If you are the author of this lint check, make your lint If you are just using lint checks from a third party library you have no control over, you can disable these lint checks (if they misbehave) like this: android { |
:warning: | app/src/debug/AndroidManifest.xml#L5 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html |
:warning: | app/src/main/AndroidManifest.xml#L7 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html |
:warning: | app/src/main/AndroidManifest.xml#L12 - Attribute networkSecurityConfig is only used in API level 24 and higher (current min is 23) |
:warning: | app/src/main/res/drawable/ic_btc_bitcoin.png#L0 - Found bitmap drawable res/drawable/ic_btc_bitcoin.png in densityless folder |
:warning: | app/src/main/res/layout/activity_main.xml#L2 - The resource R.layout.activity_main appears to be unused |
:warning: | app/src/main/res/navigation/nav_graph_main.xml#L2 - The resource R.navigation.nav_graph_main appears to be unused |
Generated by :no_entry_sign: Danger
5
What happened 👀
When the user launches the app, it will show the "My Coins" section on the Home page.
Insight 📝
CoinItem
andSeeAll
Component.Note: We will remove
Typography.kt
file in this PR as we don't use the material theme for font style and updatefont family
inTextStyle
instead. Please have a look in theStyle
class.Proof Of Work 📹
https://user-images.githubusercontent.com/28002315/180743362-2d0d5687-a663-4547-8b29-418c6b3044ca.mov