[#34] [Chore] Update Detekt rules for Jetpack Compose - Githubissues

nimblehq / jetpack-compose-crypto

This is an sample Crypto market prices app built with Jetpack Compose

https://nimblehq.co/

MIT License

21 stars 5 forks source link

[#34] [Chore] Update Detekt rules for Jetpack Compose #40

Closed luongvo closed 2 years ago

luongvo commented 2 years ago

Resolves https://github.com/nimblehq/jetpack-compose-crypto/issues/34

What happened 👀

Update Detekt rules for Jetpack Compose https://detekt.dev/docs/introduction/compose/.
Clean up unnecessary @Suppress.

Insight 📝

It's recommend to set LongMethod threshold to 60 https://github.com/detekt/detekt/issues/3251.

Proof Of Work 📹

No more weird Detekt issues in Compose.

github-actions[bot] commented 2 years ago

	3 Warnings
:warning:	app/src/main/AndroidManifest.xml#L10 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute `android:fullBackupContent` to specify an `@xml` resource which configures which files to backup, or just set `android:fullBackupOnly=true`. More info: https://developer.android.com/guide/topics/data/autobackup
:warning:	app/src/main/AndroidManifest.xml#L13 - Attribute `networkSecurityConfig` is only used in API level 24 and higher (current min is 23)
:warning:	app/src/main/res/navigation/nav_graph_main.xml#L2 - The resource `R.navigation.nav_graph_main` appears to be unused

CoroutineTemplate Jacoco report:

Generated by :no_entry_sign: Danger