nimblehq / jetpack-compose-crypto

This is an sample Crypto market prices app built with Jetpack Compose
https://nimblehq.co/
MIT License
21 stars 5 forks source link

[#33] As a user, I can see the coin image fit circular and crop in center #41

Closed hoangnguyen92dn closed 2 years ago

hoangnguyen92dn commented 2 years ago

Close #33

What happened 👀

The coin images return from API in different styles (circular, square, transparent background, etc.), the coin images are displaying inconsistency on my coins and trending coins.

Insight 📝

Proof Of Work 📹

https://user-images.githubusercontent.com/6950766/189879140-dac5757b-d0d0-4215-a1ee-61207cb2641a.mp4

luongvo commented 2 years ago

@Wadeewee @hoangnguyen92dn I think we don't need to take care of horizontal coin item width to be the same for all, right? https://nimble-co.slack.com/archives/C03KBRMUU5U/p1662689912458569?thread_ts=1662604081.664809&cid=C03KBRMUU5U

image
github-actions[bot] commented 2 years ago
3 Warnings
:warning: app/src/main/AndroidManifest.xml#L10 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup, or just set android:fullBackupOnly=true. More info: https://developer.android.com/guide/topics/data/autobackup
:warning: app/src/main/AndroidManifest.xml#L13 - Attribute networkSecurityConfig is only used in API level 24 and higher (current min is 23)
:warning: app/src/main/res/navigation/nav_graph_main.xml#L2 - The resource R.navigation.nav_graph_main appears to be unused

CoroutineTemplate Jacoco report:

Generated by :no_entry_sign: Danger

hoangnguyen92dn commented 2 years ago

@Wadeewee @hoangnguyen92dn I think we don't need to take care of horizontal coin item width to be the same for all, right? https://nimble-co.slack.com/archives/C03KBRMUU5U/p1662689912458569?thread_ts=1662604081.664809&cid=C03KBRMUU5U

image

@luongvo I think so.