search

nimblehq / jetpack-compose-crypto

This is an sample Crypto market prices app built with Jetpack Compose
https://nimblehq.co/
MIT License
21 stars 5 forks source link

[#22] [#52] Added BoxShadow in PortfolioCard in HomeScreen #53

Closed wasim15185 closed 2 years ago

wasim15185 commented 2 years ago

Resolves #22 Resolves #52

I added code for Box-Shadow in PortfolioCard Composable using Kotlin Extension Function.

And I am Sharing Preview

Before without Shadow before PortfolioCard

After adding Shadow

after PortfolioCard

luongvo commented 2 years ago

@hoangnguyen92dn From tasks assigning, you will need to continue handling this PR https://github.com/nimblehq/jetpack-compose-crypto/issues/22 👋

luongvo commented 2 years ago

Hi @wasim15185, I'm Lucas, one of the main contributors to this project 👋

That's great to see your contribution to our products and initiatives. However, after having an internal discussion with the team, this is our in-progress internal initiative so that's better for us to handle all tasks ourselves, instead of asking for code reviewing and resolving from external contributors.

The final action is: we will need to close this PR, create a new PR from our side with your work, and continue to handle the rest of the necessary tasks and requirements.

We highly appreciate your effort. Please keep in touch with us and our products. 💪