search

nimblehq / jetpack-compose-crypto

This is an sample Crypto market prices app built with Jetpack Compose
https://nimblehq.co/
MIT License
21 stars 5 forks source link

[#50] [Integrate] As a user, I can scroll down to refresh the data on Home screen #57

Closed hoangnguyen92dn closed 1 year ago

hoangnguyen92dn commented 2 years ago

Closes https://github.com/nimblehq/jetpack-compose-crypto/issues/50

What happened 👀

Insight 📝

There is an old approach with SwipeRefresh from accompanist library (https://google.github.io/accompanist/swiperefresh/), I'd go with an alternative approach from the latest release by using PullRefreshIndicator

Proof Of Work 📹

https://user-images.githubusercontent.com/6950766/196234331-6872147f-53ec-4257-9705-bf853996c08b.mp4

github-actions[bot] commented 2 years ago
8 Warnings
:warning: /home/runner/.gradle/caches/transforms-3/a0b25fd073ab83b080435226956ed8d6/transformed/jetified-dagger-lint-aar-2.43.2/jars/lint.jar#L0 - Lint found an issue registry (dagger.lint.DaggerIssueRegistry) which requires a newer API level. That means that the custom lint checks are intended for a newer lint version; please upgrade.
:warning: app/src/main/AndroidManifest.xml#L10 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup, or just set android:fullBackupOnly=true. More info: https://developer.android.com/guide/topics/data/autobackup
:warning: app/src/main/AndroidManifest.xml#L13 - Attribute networkSecurityConfig is only used in API level 24 and higher (current min is 23)
:warning: app/src/main/java/co/nimblehq/compose/crypto/ui/common/Toaster.kt#L16 - Toast created but not shown: did you forget to call show() ?
:warning: app/src/main/res/drawable/ic_back.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23)
:warning: app/src/main/res/drawable/ic_fire_opal_arrow_down.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23)
:warning: app/src/main/res/drawable/ic_guppie_green_arrow_up.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23)
:warning: app/src/main/res/navigation/nav_graph_main.xml#L2 - The resource R.navigation.nav_graph_main appears to be unused

CoroutineTemplate Jacoco report:

Generated by :no_entry_sign: Danger