Closed doannimble closed 1 year ago
@doannimble Please kindly check the CI failed 🤧
@hoangnguyen92dn The CI will fail as expected. We have another task to correct them later at here 🙏
@doannimble I am not sure if you already take a look at the CI failing check. The CI failed on Detekt
Refactoring without CI passed, how could we guarantee that the code is properly working after updating?
@hoangnguyen92dn Your concern is right but in this case, the detekt errors are about the code style. I've provided the POW that proves the code works properly after updating. However, it would be great if we could fix it. Then I decide to fix it as it is easy to do. Thanks for your suggestion 💪
@doannimble Time for UnitTest correction? :trollface:
@hoangnguyen92dn Not for now man, we have the plan to do it later at https://github.com/nimblehq/jetpack-compose-crypto/issues/82, fixing the Detekt is enough 🙏
@doannimble 🙅 Nooooo... The failed test because of unresolved reference
and I believe it doesn't take much time to fix them.
30 Warnings | |
---|---|
:warning: | Big PR |
:warning: | /home/runner/.gradle/caches/transforms-3/c5c96d5178db7f5789cb63d214efcd85/transformed/jetified-dagger-lint-aar-2.43.2/jars/lint.jar#L0 - Lint found an issue registry (dagger.lint.DaggerIssueRegistry ) which requires a newer API level. That means that the custom lint checks are intended for a newer lint version; please upgrade. |
:warning: | app/src/main/AndroidManifest.xml#L10 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup, or just set android:fullBackupOnly=true . More info: https://developer.android.com/guide/topics/data/autobackup |
:warning: | app/src/main/AndroidManifest.xml#L13 - Attribute networkSecurityConfig is only used in API level 24 and higher (current min is 23) |
:warning: | core/src/main/java/co/nimblehq/compose/crypto/core/common/Toaster.kt#L16 - Toast created but not shown: did you forget to call show() ? |
:warning: | core/src/main/res/drawable/ic_back.xml#L1 - The resource R.drawable.ic_back appears to be unused |
:warning: | core/src/main/res/drawable/ic_back.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23) |
:warning: | core/src/main/res/drawable/ic_fire_opal_arrow_down.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23) |
:warning: | core/src/main/res/drawable/ic_guppie_green_arrow_up.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23) |
:warning: | core/src/main/res/drawable/ic_heart.xml#L1 - The resource R.drawable.ic_heart appears to be unused |
:warning: | core/src/main/res/navigation/nav_graph_main.xml#L2 - The resource R.navigation.nav_graph_main appears to be unused |
:warning: | core/src/main/res/values/bools.xml#L3 - The resource R.bool.windowLightStatusBar appears to be unused |
:warning: | core/src/main/res/values/colors.xml#L4 - The resource R.color.colorBackground appears to be unused |
:warning: | core/src/main/res/values/colors_pallete.xml#L4 - The resource R.color.almost_white appears to be unused |
:warning: | core/src/main/res/values/colors_pallete.xml#L5 - The resource R.color.dark_jungle_green appears to be unused |
:warning: | core/src/main/res/values/ic_launcher_background.xml#L3 - The resource R.color.ic_launcher_background appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L3 - The resource R.string.app_name appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L6 - The resource R.string.home_title appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L7 - The resource R.string.home_my_coins_title appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L8 - The resource R.string.home_trending_title appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L9 - The resource R.string.home_see_all appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L11 - The resource R.string.detail_market_cap_title appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L12 - The resource R.string.detail_all_time_high_title appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L13 - The resource R.string.detail_all_time_low_title appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L15 - The resource R.string.portfolio_card_total_coin_label appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L16 - The resource R.string.portfolio_card_today_profit_label appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L18 - The resource R.string.coin_currency appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L21 - The resource R.string.coin_info_sell_button appears to be unused |
:warning: | core/src/main/res/values/strings.xml#L22 - The resource R.string.coin_info_buy_button appears to be unused |
:warning: | core/src/main/res/values/styles.xml#L4 - The resource R.style.AppTheme appears to be unused |
Generated by :no_entry_sign: Danger
Close https://github.com/nimblehq/jetpack-compose-crypto/issues/80
What happened 👀
Create Core module
Refactor code that depend on Core
Insight 📝
Create
core
module that included:Refactor code after moving
Proof Of Work 📹
The app still works properly.