search

nimblehq / jetpack-compose-crypto

This is an sample Crypto market prices app built with Jetpack Compose
https://nimblehq.co/
MIT License
21 stars 5 forks source link

[75] Create Feature Module for Home #88

Closed doannimble closed 1 year ago

doannimble commented 1 year ago

Close https://github.com/nimblehq/jetpack-compose-crypto/issues/75

What happened 👀

Insight 📝

Proof Of Work 📹

The app still works properly.

Screenshot_1674925898

github-actions[bot] commented 1 year ago
33 Warnings
:warning: /home/runner/.gradle/caches/transforms-3/cb6a0742f8e71c6e374d1f5f7b0e11c2/transformed/jetified-dagger-lint-aar-2.43.2/jars/lint.jar#L0 - Lint found an issue registry (dagger.lint.DaggerIssueRegistry) which requires a newer API level. That means that the custom lint checks are intended for a newer lint version; please upgrade.
:warning: app/src/main/AndroidManifest.xml#L10 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup, or just set android:fullBackupOnly=true. More info: https://developer.android.com/guide/topics/data/autobackup
:warning: app/src/main/AndroidManifest.xml#L13 - Attribute networkSecurityConfig is only used in API level 24 and higher (current min is 23)
:warning: core/src/main/java/co/nimblehq/compose/crypto/core/common/Toaster.kt#L16 - Toast created but not shown: did you forget to call show() ?
:warning: core/src/main/res/drawable/ic_back.xml#L1 - The resource R.drawable.ic_back appears to be unused
:warning: core/src/main/res/drawable/ic_back.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23)
:warning: core/src/main/res/drawable/ic_fire_opal_arrow_down.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23)
:warning: core/src/main/res/drawable/ic_guppie_green_arrow_up.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23)
:warning: core/src/main/res/drawable/ic_heart.xml#L1 - The resource R.drawable.ic_heart appears to be unused
:warning: core/src/main/res/mipmap-anydpi-v26/ic_launcher.xml#L2 - The resource R.mipmap.ic_launcher appears to be unused
:warning: core/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml#L2 - The resource R.mipmap.ic_launcher_round appears to be unused
:warning: core/src/main/res/mipmap-hdpi/ic_launcher_foreground.png#L0 - The resource R.mipmap.ic_launcher_foreground appears to be unused
:warning: core/src/main/res/navigation/nav_graph_main.xml#L2 - The resource R.navigation.nav_graph_main appears to be unused
:warning: core/src/main/res/values/bools.xml#L3 - The resource R.bool.windowLightStatusBar appears to be unused
:warning: core/src/main/res/values/colors.xml#L4 - The resource R.color.colorBackground appears to be unused
:warning: core/src/main/res/values/colors_pallete.xml#L4 - The resource R.color.almost_white appears to be unused
:warning: core/src/main/res/values/colors_pallete.xml#L5 - The resource R.color.dark_jungle_green appears to be unused
:warning: core/src/main/res/values/ic_launcher_background.xml#L3 - The resource R.color.ic_launcher_background appears to be unused
:warning: core/src/main/res/values/strings.xml#L3 - The resource R.string.app_name appears to be unused
:warning: core/src/main/res/values/strings.xml#L6 - The resource R.string.home_title appears to be unused
:warning: core/src/main/res/values/strings.xml#L7 - The resource R.string.home_my_coins_title appears to be unused
:warning: core/src/main/res/values/strings.xml#L8 - The resource R.string.home_trending_title appears to be unused
:warning: core/src/main/res/values/strings.xml#L9 - The resource R.string.home_see_all appears to be unused
:warning: core/src/main/res/values/strings.xml#L11 - The resource R.string.detail_market_cap_title appears to be unused
:warning: core/src/main/res/values/strings.xml#L12 - The resource R.string.detail_all_time_high_title appears to be unused
:warning: core/src/main/res/values/strings.xml#L13 - The resource R.string.detail_all_time_low_title appears to be unused
:warning: core/src/main/res/values/strings.xml#L15 - The resource R.string.portfolio_card_total_coin_label appears to be unused
:warning: core/src/main/res/values/strings.xml#L16 - The resource R.string.portfolio_card_today_profit_label appears to be unused
:warning: core/src/main/res/values/strings.xml#L18 - The resource R.string.coin_currency appears to be unused
:warning: core/src/main/res/values/strings.xml#L21 - The resource R.string.coin_info_sell_button appears to be unused
:warning: core/src/main/res/values/strings.xml#L22 - The resource R.string.coin_info_buy_button appears to be unused
:warning: core/src/main/res/values/styles.xml#L4 - The resource R.style.AppTheme appears to be unused
:warning: core/src/main/res/xml/network_security_config.xml#L1 - The resource R.xml.network_security_config appears to be unused

CoroutineTemplate Jacoco report:

Generated by :no_entry_sign: Danger

kaungkhantsoe commented 1 year ago

@doannimble Can you try posting PoW with video please? I have been trying to run the app and it keeps crashing with 

Cannot create an instance of class co.nimblehq.compose.crypto.feature.home.HomeViewModel

I have tried clear cache and restart the AS. The error doesn't go away.

doannimble commented 1 year ago

@kaungkhantsoe Sorry, I've not updated the latest config of the feature module. Please pull and double-check again 🙏