[#4] Set up Detekt, Danger, and CI: Github Action

lydiasama commented 1 year ago

Close #4

What happened 👀

[x] Set up Detekt for checking format and analytic code
[x] Set up Danger
[x] Set up the Github Action CI workflow

Insight 📝

Reused the detekt rules from Android Templates::template-compose for supporting Jetpack Compose layout implement. But after running:
```
./gradlew detekt
```

There are many warning throws:

SCR-25660727-qfkp

I think we should consider adding some more rules to ignore this later. 🙏🏻

Proof Of Work 📹

SCR-25660727-qgno

lydiasama commented 12 months ago

@phongvhd93 It's weird that every time we re-sync gradle, it will create the white space like that. 🙈

phongvhd93 commented 11 months ago

@phongvhd93 It's weird that every time we re-sync gradle, it will create the white space like that. 🙈

We can manually remove them and find a solution for that later

luongvo commented 11 months ago

@lydiasama This PR should be based on https://github.com/nimblehq/kmm-templates/pull/28 to verify the generated project changes.

phongvhd93 commented 11 months ago

@lydiasama Let's rebase this to develop

bot-nimble commented 11 months ago

	6 Warnings
:warning:	Uh oh! Your project is under 80% coverage!
:warning:	shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
:warning:	shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
:warning:	shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
:warning:	shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
:warning:	shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: `3.34%`

Coverage of Modified Files:

File	Coverage

Modified Files Not Found In Coverage Report:

Dangerfile Gemfile build.gradle.kts build.gradle.kts build.gradle.kts detekt.yml shared.podspec test.yml

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

lydiasama commented 11 months ago

@luongvo Updated. This time must get passed! 🔥

nimblehq / kmm-templates