Closed lydiasama closed 11 months ago
10 Warnings | |
---|---|
:warning: | android/src/main/java/co/nimblehq/kmm/template/android/MyApplicationTheme.kt#L25 - This expression contains a magic number. Consider defining it to a well named constant. |
:warning: | android/src/main/java/co/nimblehq/kmm/template/android/MyApplicationTheme.kt#L26 - This expression contains a magic number. Consider defining it to a well named constant. |
:warning: | android/src/main/java/co/nimblehq/kmm/template/android/MyApplicationTheme.kt#L27 - This expression contains a magic number. Consider defining it to a well named constant. |
:warning: | android/src/main/java/co/nimblehq/kmm/template/android/MyApplicationTheme.kt#L31 - This expression contains a magic number. Consider defining it to a well named constant. |
:warning: | android/src/main/java/co/nimblehq/kmm/template/android/MyApplicationTheme.kt#L32 - This expression contains a magic number. Consider defining it to a well named constant. |
:warning: | android/src/main/java/co/nimblehq/kmm/template/android/MyApplicationTheme.kt#L33 - This expression contains a magic number. Consider defining it to a well named constant. |
:warning: | shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'. |
:warning: | shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'. |
:warning: | shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'. |
:warning: | shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'. |
NaN%
File | Coverage |
---|
Dangerfile Gemfile build.gradle.kts test.yml
Codebase cunningly covered by count Shroud 🧛
Generated by :no_entry_sign: Danger
@luongvo All updated. 🙏🏻
@luongvo Now I moved the Kover set up to be in android/build.gradle.kts
; my question is, how about the ::shared
? Do we have another ticket for ::shared
to set it up? And will we set up the Kover in ::shared
too?
@luongvo Now I moved the Kover set up to be in
android/build.gradle.kts
; my question is, how about the::shared
? Do we have another ticket for::shared
to set it up? And will we set up the Kover in::shared
too?
@lydiasama Nice question. As the "shared" module is a Kotlin module, we should also set up Kover for the shared in this task, same as Detekt. 🙏
Since there're not much changes, So I combine this with Part1. I'll close this PR. 🙏🏻
What happened 👀
Insight 📝
I tried using the danger-kotlin, but it cannot run successfully The log is here. To speed up our implementation, I roll-backed to the danger-ruby version instead.
Proof Of Work 📹
Danger integration is successful:
https://github.com/nimblehq/kmm-templates/pull/18#issuecomment-1663270590