nimblehq / kmm-templates

MIT License
2 stars 0 forks source link

[#5] [iOS] Setup CI: Github Actions #23

Closed markgravity closed 1 year ago

markgravity commented 1 year ago

What happened 👀

Insight 📝

n/a

Proof Of Work 📹

CleanShot 2023-08-24 at 15 52 32

phongvhd93 commented 1 year ago

@markgravity; the CI failed, please check the issue.

markgravity commented 1 year ago

@phongvhd93 It gotta fix on your PR first, it's because the Podfile target is 14.0, but our Podspec is 14.1 🙏 https://github.com/nimblehq/kmm-templates/pull/19/files/dc770193cd02994b186874d800b7664e45417d2a#diff-cf9ae3b1eb7273a914f22b1e6d22d8447f88df0e7245a5b856fb751e507b979b

phongvhd93 commented 1 year ago

@phongvhd93 It gotta fix on your PR first, it's because the Podfile target is 14.0, but our Podspec is 14.1 🙏 https://github.com/nimblehq/kmm-templates/pull/19/files/dc770193cd02994b186874d800b7664e45417d2a#diff-cf9ae3b1eb7273a914f22b1e6d22d8447f88df0e7245a5b856fb751e507b979b

I solved the issue and set the ios version based on the user's input.

luongvo commented 1 year ago

This PR should be based on https://github.com/nimblehq/kmm-templates/pull/28 to verify the generated project changes.

phongvhd93 commented 1 year ago

@markgravity; please resolve the conflict

luongvo commented 1 year ago

@markgravity please let me know when this PR is ready for review, especially this issue. We already have a job for test Android & Shared modules on develop, imo, I think we can create a new job in that test.yml workflow 🙏

luongvo commented 1 year ago

@markgravity is this the latest report from danger? Should we have coverage data there? Should we delete that report message and re-run it to verify again, please?

image

github-actions[bot] commented 1 year ago

Current coverage for sample is 18.25%

No files affecting coverage found


Powered by xcov

Generated by :no_entry_sign: Danger

markgravity commented 1 year ago

@luongvo solved at ebb5630