Closed markgravity closed 1 year ago
@markgravity; the CI failed, please check the issue.
@phongvhd93 It gotta fix on your PR first, it's because the Podfile target is 14.0, but our Podspec is 14.1 🙏 https://github.com/nimblehq/kmm-templates/pull/19/files/dc770193cd02994b186874d800b7664e45417d2a#diff-cf9ae3b1eb7273a914f22b1e6d22d8447f88df0e7245a5b856fb751e507b979b
@phongvhd93 It gotta fix on your PR first, it's because the Podfile target is 14.0, but our Podspec is 14.1 🙏 https://github.com/nimblehq/kmm-templates/pull/19/files/dc770193cd02994b186874d800b7664e45417d2a#diff-cf9ae3b1eb7273a914f22b1e6d22d8447f88df0e7245a5b856fb751e507b979b
I solved the issue and set the ios version based on the user's input.
This PR should be based on https://github.com/nimblehq/kmm-templates/pull/28 to verify the generated project changes.
@markgravity; please resolve the conflict
@markgravity please let me know when this PR is ready for review, especially this issue. We already have a job for test Android & Shared modules on develop
, imo, I think we can create a new job in that test.yml workflow 🙏
@markgravity is this the latest report from danger? Should we have coverage data there? Should we delete that report message and re-run it to verify again, please?
@luongvo solved at ebb5630
What happened 👀
Setup CI pipeline for iOS
On
make.sh
:--exclude './sample' \
so that it won't ignoresample/ios/sample
folder./sample/ios/dangerfile
On
make_ios.sh
:On
android/build.gradle.kts
:rootDir.loadGradleProperties("signing.properties")
as the previous one doesn't work on iOSInsight 📝
n/a
Proof Of Work 📹