nimblehq / kmm-templates

MIT License
2 stars 0 forks source link

[#29] 2/2 - Reuse the "android" module from android-templates #32

Closed luongvo closed 10 months ago

luongvo commented 11 months ago

What happened 👀

Insight 📝

Proof Of Work 📹

image
github-actions[bot] commented 11 months ago
17 Warnings
:warning: Big PR
:warning: Uh oh! AppDestination.kt is under 95% coverage!
:warning: Uh oh! AppNavigation.kt is under 95% coverage!
:warning: Uh oh! BaseViewModel.kt is under 95% coverage!
:warning: Uh oh! ErrorMapping.kt is under 95% coverage!
:warning: Uh oh! FlowExt.kt is under 95% coverage!
:warning: Uh oh! HomeScreen.kt is under 95% coverage!
:warning: Uh oh! Theme.kt is under 95% coverage!
:warning: Uh oh! UiModel.kt is under 95% coverage!
:warning: Uh oh! Your project is under 80% coverage!
:warning: android/src/main/java/co/nimblehq/kmm/template/ui/screens/home/HomeScreen.kt#L66 - This expression contains a magic number. Consider defining it to a well named constant.
:warning: shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
:warning: shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
:warning: shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
:warning: shared/src/commonTest/kotlin/co/nimblehq/kmm/template/extensions/ResponseMappingTest.kt#L18 - Exception is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
:warning: shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
:warning: shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: 59.92%

Coverage of Modified Files:

File Coverage
AppColors.kt 98.11%
AppDestination.kt 83.87%
AppDimensions.kt 100.00%
AppNavigation.kt 52.63%
AppShapes.kt 100.00%
AppTypography.kt 100.00%
BaseViewModel.kt 73.91%
ContextExt.kt 100.00%
ErrorMapping.kt 88.00%
FlowExt.kt 76.19%
HomeScreen.kt 64.16%
HomeViewModel.kt 100.00%
MainActivity.kt 100.00%
MainApplication.kt 100.00%
Theme.kt 46.09%
UiModel.kt 84.21%

Modified Files Not Found In Coverage Report:

.gitignore .gitmodules AndroidManifest.xml AndroidManifest.xml AppModule.kt BaseScreenTest.kt CoroutineTestRule.kt Dependencies.kt Dependencies.kt DispatchersProvider.kt DispatchersProvider.kt HomeScreenTest.kt HomeViewModelTest.kt MockUtil.kt Plugins.kt Plugins.kt Versions.kt Versions.kt ViewModelModule.kt android backup_rules.xml build.gradle.kts data_extraction_rules.xml ic_launcher.webp ic_launcher.webp ic_launcher.webp ic_launcher.webp ic_launcher.webp ic_launcher.xml ic_launcher_background.xml ic_launcher_foreground.xml ic_launcher_round.webp ic_launcher_round.webp ic_launcher_round.webp ic_launcher_round.webp ic_launcher_round.webp ic_launcher_round.xml make.sh make_android.sh network_security_config.xml network_security_config.xml proguard-rules.pro project.pbxproj robolectric.properties settings.gradle.kts settings.gradle.kts strings.xml strings.xml test.yml test.yml themes.xml

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

github-actions[bot] commented 11 months ago
1 Warning
:warning: This pull request is quite big (1980 lines changed), please consider splitting it into multiple pull requests.

Current coverage for sample is 18.25%

No files affecting coverage found


Powered by xcov

Generated by :no_entry_sign: Danger

luongvo commented 10 months ago

@kaungkhantsoe @phongvhd93 Can I have your reviews here?

lydiasama commented 10 months ago

It isn't a big deal. Just only optional things. So approve.

luongvo commented 10 months ago

@phongvhd93 your turn 💁‍♂️