nimblehq / kmm-templates

MIT License
2 stars 0 forks source link

[#17] [iOS] Remove unnecessary libraries in Podfile #36

Closed phongvhd93 closed 11 months ago

phongvhd93 commented 11 months ago

What happened 👀

Create a script to remove the RxAlamofire from Pod, since the API requests are handled by share module in a KMM project. I also updated the test workflow to preserve the Arkana keys, which will eliminate the need for rebasing when developers push new code to their branch.

Insight 📝

Proof Of Work 📹

There will be no changes related to ArkanaKeys folder in this PR. The Sample app's Podfile and Pod lock won't contain RxAlamofire.

bot-nimble commented 11 months ago

Current coverage for sample is 18.25%

No files affecting coverage found


Powered by xcov

Generated by :no_entry_sign: Danger

luongvo commented 11 months ago

@phongvhd93 @markgravity is there any chance to merge this PR after https://github.com/nimblehq/kmm-templates/pull/23 to verify the project's buildable and testable ability? To do that, we need https://github.com/nimblehq/kmm-templates/pull/23 to be completed, reviewed and merged first 🙏

phongvhd93 commented 11 months ago

@luongvo, I'll rebase this on Mark's pr

luongvo commented 11 months ago

@phongvhd93 please re-request Mark for review 🙏