search

nimblehq / kmm-templates

MIT License
2 stars 0 forks source link

[#13] [Part 2] Implement the base Clean Architecture with MVVM: data and domain layer #37

Closed kaungkhantsoe closed 11 months ago

kaungkhantsoe commented 11 months ago

What happened 👀

Insight 📝

N/A

Proof Of Work 📹

Screenshot 2023-08-23 at 6 10 50 PM
bot-nimble commented 11 months ago
11 Warnings
:warning: Big PR
:warning: Uh oh! ApiClient.kt is under 95% coverage!
:warning: Uh oh! ApiException.kt is under 95% coverage!
:warning: Uh oh! HttpRequestBuilderExtension.kt is under 95% coverage!
:warning: Uh oh! UserRemoteDataSource.kt is under 95% coverage!
:warning: Uh oh! Your project is under 80% coverage!
:warning: shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
:warning: shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
:warning: shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
:warning: shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
:warning: shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: 10.68%

Coverage of Modified Files:

File Coverage
ApiClient.kt 0.00%
ApiException.kt 0.00%
GetUsersUseCase.kt 100.00%
HttpRequestBuilderExtension.kt 0.00%
RepositoryImpl.kt 100.00%
ResponseMapping.kt 100.00%
UserModel.kt 100.00%
UserRemoteDataSource.kt 0.00%
UserResponse.kt 100.00%

Modified Files Not Found In Coverage Report:

.gitignore AndroidManifest.xml Configurations.kt Dependencies.kt Fake.kt GetUsersUseCaseTest.kt PlatformModule.kt PlatformModule.kt RemoteModule.kt Repository.kt RepositoryModule.kt RepositoryTest.kt ResponseMappingTest.kt UseCaseModule.kt build.gradle.kts build.gradle.kts build.gradle.kts build.gradle.kts build.gradle.kts buildKonfig.properties.sample detekt.yml detekt.yml test.yml

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

luongvo commented 11 months ago

@kaungkhantsoe is this PR ready for review yet?

kaungkhantsoe commented 11 months ago

@kaungkhantsoe is this PR ready for review yet?

Not yet @luongvo, I am still working on it. 🙏