[#29] 1/2 - Prepare some necessary changes in the shared module before applying the Android submodule

luongvo commented 11 months ago

What happened 👀

Fix the make_ios script to be re-run multiple times continuously.
Refactor Android module dependencies in the shared module.
Refactor component names (remove User from all components) & packages in the shared module.
Rename Android's app id to co.nimblehq.kmm.template.

Insight 📝

Use the plural for packages with homogeneous contents and the singular for packages with heterogeneous contents. softwareengineering.stackexchange.com/questions/75919/should-package-names-be-singular-or-plural.
The generated iOS source code should be cleaned up before executing the next run.

Proof Of Work 📹

The iOS script is now able to be re-run multiple times continuously ✅

https://github.com/nimblehq/kmm-templates/assets/16315358/e5b02d2c-2a9e-44e8-8684-be1d566db04b

github-actions[bot] commented 11 months ago

	20 Warnings
:warning:	Big PR
:warning:	Uh oh! AppColors.kt is under 95% coverage!
:warning:	Uh oh! AppDestination.kt is under 95% coverage!
:warning:	Uh oh! AppDimensions.kt is under 95% coverage!
:warning:	Uh oh! AppNavigation.kt is under 95% coverage!
:warning:	Uh oh! AppStyles.kt is under 95% coverage!
:warning:	Uh oh! BaseViewModel.kt is under 95% coverage!
:warning:	Uh oh! DispatchersProvider.kt is under 95% coverage!
:warning:	Uh oh! HomeScreen.kt is under 95% coverage!
:warning:	Uh oh! LogUtil.kt is under 95% coverage!
:warning:	Uh oh! MainActivity.kt is under 95% coverage!
:warning:	Uh oh! MyApplication.kt is under 95% coverage!
:warning:	Uh oh! RemoteDataSource.kt is under 95% coverage!
:warning:	Uh oh! Theme.kt is under 95% coverage!
:warning:	Uh oh! Your project is under 80% coverage!
:warning:	shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
:warning:	shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
:warning:	shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
:warning:	shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
:warning:	shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: `10.68%`

Coverage of Modified Files:

File	Coverage
`AppColors.kt`	`0.00%`
`AppDestination.kt`	`0.00%`
`AppDimensions.kt`	`0.00%`
`AppNavigation.kt`	`0.00%`
`AppStyles.kt`	`0.00%`
`BaseViewModel.kt`	`0.00%`
`DispatchersProvider.kt`	`0.00%`
`HomeScreen.kt`	`0.00%`
`LogUtil.kt`	`0.00%`
`MainActivity.kt`	`0.00%`
`Model.kt`	`100.00%`
`MyApplication.kt`	`0.00%`
`RemoteDataSource.kt`	`0.00%`
`RepositoryImpl.kt`	`100.00%`
`Response.kt`	`100.00%`
`Theme.kt`	`0.00%`
`UseCase.kt`	`100.00%`

Modified Files Not Found In Coverage Report:

AndroidManifest.xml AndroidManifest.xml BuildTypes.kt BuildTypes.kt Configurations.kt Configurations.kt CoroutineTestRule.kt CoroutineTestRule.kt Dependencies.kt Dependencies.kt Fake.kt Fake.kt Flavors.kt Flavors.kt GetUsersUseCaseTest.kt GetUsersUseCaseTest.kt Koin.kt Koin.kt Modules.kt Modules.kt PlatformModule.kt PlatformModule.kt PlatformModule.kt PlatformModule.kt PlatformModule.kt PlatformModule.kt RemoteModule.kt RemoteModule.kt Repository.kt Repository.kt RepositoryModule.kt RepositoryModule.kt RepositoryTest.kt RepositoryTest.kt ResponseMappingTest.kt ResponseMappingTest.kt TypeAlias.kt TypeAlias.kt UseCaseModule.kt UseCaseModule.kt Versions.kt Versions.kt ViewModelModule.kt ViewModelModule.kt build.gradle.kts build.gradle.kts build.gradle.kts build.gradle.kts buildKonfig.properties.sample make.sh make_ios.sh project.pbxproj

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

github-actions[bot] commented 11 months ago

	1 Warning
:warning:	This pull request is quite big (1065 lines changed), please consider splitting it into multiple pull requests.

Current coverage for sample is `18.25%`

✅ No files affecting coverage found

Powered by xcov

Generated by :no_entry_sign: Danger

suho commented 11 months ago

@luongvo 103 files changed is too much to review. Could you help me to check if we can separate this into small pull requests?

luongvo commented 11 months ago

@suho I think we should not count sample folder changes. It's optional for reviewing to verify our core template changes so basically just half of changes ~ 50 files 🤓

luongvo commented 10 months ago

LGTM. I was wondering, can't we add git submodule update --init --recursive to make.sh to reduce a step? 🤔

@AVI5HEK that command must be executed 1 time to fetch the submodule, while make.sh is a script to be executed multiple times, e.g., in local development 🙏

luongvo commented 10 months ago

@kaungkhantsoe @phongvhd93 Can I have your reviews here?

nimblehq / kmm-templates