[12] Integrate Moko Resources to share project resources between platforms

AVI5HEK commented 10 months ago

Close #12

What happened 👀

Add Moko Resources to the template.

Insight 📝

Added Moko Resources according to the instructions on the official GitHub page and with the help of this video.
For some reason, the :shared module fails to build if we add the dependency dev.icerock.moko:resources-compose:0.23.0. This line has been commented out for now until a resolution is found.
Added expect and actual classes and methods of Strings as a helper to get the strings from Moko resources in both the Android and iOS apps.

Proof Of Work 📹

Android

iOS

github-actions[bot] commented 10 months ago

	10 Warnings
:warning:	Big PR
:warning:	Uh oh! HomeScreen.kt is under 95% coverage!
:warning:	Uh oh! Strings.kt is under 95% coverage!
:warning:	Uh oh! Your project is under 80% coverage!
:warning:	shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
:warning:	shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
:warning:	shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
:warning:	shared/src/commonTest/kotlin/co/nimblehq/kmm/template/extensions/ResponseMappingTest.kt#L18 - Exception is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
:warning:	shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
:warning:	shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: `10.31%`

Coverage of Modified Files:

File	Coverage
`HomeScreen.kt`	`0.00%`
`Strings.kt`	`0.00%`

Modified Files Not Found In Coverage Report:

Dependencies.kt Dependencies.kt Gemfile.lock Plugins.kt Plugins.kt Podfile.lock Versions.kt Versions.kt build.gradle.kts build.gradle.kts build.gradle.kts build.gradle.kts project.pbxproj strings.xml strings.xml

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

github-actions[bot] commented 10 months ago

	1 Warning
:warning:	This pull request is quite big (554 lines changed), please consider splitting it into multiple pull requests.

Current coverage for sample is `18.25%`

✅ No files affecting coverage found

Powered by xcov

Generated by :no_entry_sign: Danger

luongvo commented 10 months ago

@AVI5HEK Please base this PR on #32 to reuse the Android app module from Android Templates, then try a way to inject your new changes for the KMM Templates 🙏

nimblehq / kmm-templates