search

nimblehq / kmm-templates

MIT License
2 stars 0 forks source link

[Chore] Sync main and release #46

Closed phongvhd93 closed 9 months ago

phongvhd93 commented 9 months ago

What happened 👀

This PR is to solve a conflict between main and release/0.2.0

Insight 📝

Proof Of Work 📹

N/A

luongvo commented 9 months ago

@phongvhd93 Let's point this to develop, then reset your release branch to dev after merging 🙏

phongvhd93 commented 9 months ago

@phongvhd93 Let's point this to develop, then reset your release branch to dev after merging 🙏

Done

github-actions[bot] commented 9 months ago
8 Warnings
:warning: Uh oh! Your project is under 80% coverage!
:warning: android/src/main/java/co/nimblehq/kmm/template/ui/screens/home/HomeScreen.kt#L66 - This expression contains a magic number. Consider defining it to a well named constant.
:warning: shared/src/androidMain/kotlin/co/nimblehq/kmm/template/Platform.android.kt#L3 - The file name 'Platform.android' does not match the name of the single top-level declaration 'AndroidPlatform'.
:warning: shared/src/androidUnitTest/kotlin/co/nimblehq/kmm/template/androidTest.kt#L6 - The file name 'androidTest' does not match the name of the single top-level declaration 'AndroidGreetingTest'.
:warning: shared/src/commonTest/kotlin/co/nimblehq/kmm/template/commonTest.kt#L6 - The file name 'commonTest' does not match the name of the single top-level declaration 'CommonGreetingTest'.
:warning: shared/src/commonTest/kotlin/co/nimblehq/kmm/template/extensions/ResponseMappingTest.kt#L18 - Exception is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
:warning: shared/src/iosMain/kotlin/co/nimblehq/kmm/template/Platform.ios.kt#L5 - The file name 'Platform.ios' does not match the name of the single top-level declaration 'IOSPlatform'.
:warning: shared/src/iosTest/kotlin/co/nimblehq/kmm/template/iosTest.kt#L6 - The file name 'iosTest' does not match the name of the single top-level declaration 'IosGreetingTest'.

Kover report:

🧛 Unit Tests Code Coverage: 59.92%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

Gemfile.lock Podfile.lock project.pbxproj

Codebase cunningly covered by count Shroud 🧛

Generated by :no_entry_sign: Danger

github-actions[bot] commented 9 months ago

Current coverage for sample is 18.25%

✅ No files affecting coverage found

Powered by xcov

Generated by :no_entry_sign: Danger