Remove Pronto and setup Danger for automated code review
Insight
Remove completely pronto related things
Add danger gem and its plugins
Create a new workflow for danger checks:
I want danger to run as fast as possible, so I create a new workflow and just install node, ruby, bundler and run dependencies installers instead of using docker
Add caching to improve the checks
Add team-nimblehq as bot:
Add team-nimblehq to repo with write access (use write instead of read as we need to set the status of the PR)
Create a new token for team-nimblehq with public_repo access
Because of removing pronto-eslint_npm that includes scss_lint, we have to install scss_lint to use scss_lint
List of danger plugins:
gem 'danger-brakeman_scanner' # Security static analysis scanner in danger
gem 'danger-eslint' # Lint JavaScript code
gem 'danger-rails_best_practices' # Analyze code regarding best practices
gem 'danger-reek' # Detect code smell
gem 'danger-rubocop' # A Danger plugin for Rubocop
gem 'danger-slim_lint' # Lint slim files
gem 'danger-suggester' # Suggest code changes based on configured code
Remove duplicated checks in codebase_spec
Run workflow with pull_request event and [opened, reopened, synchronize] types
What happened
Remove Pronto and setup Danger for automated code review
Insight
pronto
related thingsdanger
gem and its pluginsteam-nimblehq
as bot:team-nimblehq
to repo withwrite
access (usewrite
instead ofread
as we need to set the status of the PR)team-nimblehq
withpublic_repo
accesspronto-eslint_npm
that includesscss_lint
, we have to installscss_lint
to use scss_lintcodebase_spec
pull_request
event and[opened, reopened, synchronize]
typesProof Of Work
We should have automated reviews on this PR