Support dynamic docker registry - Githubissues

nimblehq / nimble-survey-web

Nimble Survey API for Mobile Challenge and Certification

0 stars 3 forks source link

Support dynamic docker registry #39

Closed hoangmirs closed 4 years ago

hoangmirs commented 4 years ago

What happened

Github introduced the Github Container Registry at the beginning of the month
Try using it

Insight

Modify the Docker image name so that it can be used for both docker.io and ghcr.io
Modify Github actions workflows to be able to log in with different registries
To avoid set DOCKER_REGISTRY manually in the workflows, use secrets instead

Proof Of Work

Tested and worked for both registries(docker.io and ghcr.io)
Try deploying on staging and it works perfectly

olivierobert commented 4 years ago

Do you have a screenshot of the image being uploaded to Github Container registry?